Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry billing update in project creation #1131

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Retry billing update in project creation #1131

merged 5 commits into from
Nov 19, 2024

Conversation

crhino
Copy link
Contributor

@crhino crhino commented Nov 12, 2024 •
edited
Loading

HCPF-2286

🛠️ Description

Building the provider locally and running many project creations at once, I see:

2024-11-14T10:39:46.626-0500 [DEBUG] provider.terraform-provider-hcp: {"code":14, "message":"failed to update billing account", "details":[]}
2024-11-14T10:39:46.626-0500 [WARN]  unexpected data: localhost/providers/hcp:stdout="Error trying to update billing account. Retrying in 10 seconds..."

and that all projects create successfully given time:

hcp_project.proj["project16"]: Creation complete after 1s [name=project16]
hcp_project.proj["project10"]: Still creating... [10s elapsed]
hcp_project.proj["project12"]: Still creating... [10s elapsed]
hcp_project.proj["project12"]: Creation complete after 11s [name=project12]
hcp_project.proj["project10"]: Creation complete after 11s [name=project10]

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...
=== RUN   TestAccProjectResource
--- PASS: TestAccProjectResource (5.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider/resourcemanager	8.092s

@crhino crhino marked this pull request as ready for review November 14, 2024 16:06
@crhino crhino requested review from a team as code owners November 14, 2024 16:06
@pierluc-codes
Copy link
Contributor

pierluc-codes commented Nov 15, 2024 •
edited
Loading

@crhino can you explain why the retries are necessary? Especially on a 503.

@pierluc-codes pierluc-codes mentioned this pull request Nov 18, 2024
Merged
3 tasks
@crhino
Copy link
Contributor Author

crhino commented Nov 18, 2024

@crhino can you explain why the retries are necessary? Especially on a 503.

@pierluc-codes

Sure. This essentially stems from a race condition in the billing system. When creating a large number of projects, each of those projects needs to be added to the same billing account, as the TF provider does here. Those UpdateBilling calls conflict with each other and some of them return an Unavailable error, which is then translated to a 503. In general, I believe a 503 status code is considered reasonable to retry on anyways.

pierluc-codes
pierluc-codes approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@pierluc-codes pierluc-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I would encourage you to fix your race condition instead.

@crhino crhino merged commit 921447b into main Nov 19, 2024
6 checks passed
@crhino crhino deleted the hcpf-2286/retry-project-creation branch November 19, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierluc-codes pierluc-codes pierluc-codes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crhino @pierluc-codes